]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.12] gh-108963: using random to generate unique string in sys.intern test … (#110216)
authorVictor Stinner <vstinner@python.org>
Mon, 2 Oct 2023 15:48:42 +0000 (17:48 +0200)
committerGitHub <noreply@github.com>
Mon, 2 Oct 2023 15:48:42 +0000 (17:48 +0200)
gh-108963: using random to generate unique string in sys.intern test (#109491)

(cherry picked from commit 44b1e4ea4842c6cdc1bedba7aaeb93f236b3ec08)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
Lib/test/test_sys.py

index c3e9f9c406815fa731a5a54bd4115f498a91b320..0b8529a9b6abd0fa0af88b1a9da43f4a32d3b105 100644 (file)
@@ -4,6 +4,7 @@ import gc
 import locale
 import operator
 import os
+import random
 import struct
 import subprocess
 import sys
@@ -19,10 +20,6 @@ import unittest
 import warnings
 
 
-# count the number of test runs, used to create unique
-# strings to intern in test_intern()
-INTERN_NUMRUNS = 0
-
 DICT_KEY_STRUCT_FORMAT = 'n2BI2n'
 
 class DisplayHookTest(unittest.TestCase):
@@ -685,10 +682,8 @@ class SysModuleTest(unittest.TestCase):
         self.assertEqual(sys.__stdout__.encoding, sys.__stderr__.encoding)
 
     def test_intern(self):
-        global INTERN_NUMRUNS
-        INTERN_NUMRUNS += 1
         self.assertRaises(TypeError, sys.intern)
-        s = "never interned before" + str(INTERN_NUMRUNS)
+        s = "never interned before" + str(random.randrange(0, 10**9))
         self.assertTrue(sys.intern(s) is s)
         s2 = s.swapcase().swapcase()
         self.assertTrue(sys.intern(s2) is s)