]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: atmel-sha204a - fix negated return value
authorLothar Rubusch <l.rubusch@gmail.com>
Sun, 26 May 2024 10:31:28 +0000 (10:31 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Aug 2024 07:00:07 +0000 (09:00 +0200)
[ Upstream commit aabbf2135f9a9526991f17cb0c78cf1ec878f1c2 ]

Fix negated variable return value.

Fixes: e05ce444e9e5 ("crypto: atmel-sha204a - add reading from otp zone")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-crypto/34cd4179-090e-479d-b459-8d0d35dd327d@moroto.mountain/
Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/atmel-sha204a.c

index 24ffdf50502356d446411671cb769beb26b42166..2034f60315183734a92091c38c6076800d8df861 100644 (file)
@@ -106,7 +106,7 @@ static int atmel_sha204a_otp_read(struct i2c_client *client, u16 addr, u8 *otp)
 
        if (cmd.data[0] == 0xff) {
                dev_err(&client->dev, "failed, device not ready\n");
-               return -ret;
+               return -EINVAL;
        }
 
        memcpy(otp, cmd.data+1, 4);