]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/atomic: Convert drm_atomic_get_connector_state() to use new connector state
authorMaxime Ripard <mripard@kernel.org>
Tue, 30 Sep 2025 10:59:16 +0000 (12:59 +0200)
committerMaxime Ripard <mripard@kernel.org>
Mon, 6 Oct 2025 11:58:53 +0000 (13:58 +0200)
The drm_atomic_get_connector_state() function calls a hand-rolled
implementation of the deprecated
drm_atomic_get_existing_connector_state() helper to get find if a
connector state had already been allocated and was part of the given
drm_atomic_state.

At the point in time where drm_atomic_get_connector_state() can be
called (ie, during atomic_check), the existing state is the new state
and drm_atomic_get_existing_connector_state() can thus be replaced by
drm_atomic_get_new_connector_state().

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # on imx8mp
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/20250930-drm-no-more-existing-state-v5-1-eeb9e1287907@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/drm_atomic.c

index ed5359a71f7e2cd8fa52b993e62ee65f8fed4537..eeae4553894c1494106ba054af5c90e46abf703f 100644 (file)
@@ -1152,8 +1152,9 @@ drm_atomic_get_connector_state(struct drm_atomic_state *state,
                state->num_connector = alloc;
        }
 
-       if (state->connectors[index].state)
-               return state->connectors[index].state;
+       connector_state = drm_atomic_get_new_connector_state(state, connector);
+       if (connector_state)
+               return connector_state;
 
        connector_state = connector->funcs->atomic_duplicate_state(connector);
        if (!connector_state)