Fix clang 9 logical-not-parentheses warnings

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/buildtools/wafsamba/samba_autoconf.py b/buildtools/wafsamba/samba_autoconf.py
index 5098648efd7f883ebf52c553a3fcf58e3f7f3367..caa97b8e868c6ae97a9421087eb6e3bb1e126184 100644 (file)
--- a/buildtools/wafsamba/samba_autoconf.py
+++ b/buildtools/wafsamba/samba_autoconf.py
@@ -796,7 +796,6 @@ int main(void) {
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=missing-field-initializers', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=unused-function', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=enum-conversion', testflags=True)
-            conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=logical-not-parentheses', testflags=True)
             conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=constant-conversion', testflags=True)
 
     if Options.options.fatal_errors:

diff --git a/source4/torture/gpo/apply.c b/source4/torture/gpo/apply.c
index de5836d1a5f22da828d5aea2ba96920094357509..c4a6499f4cc8cf7c126972b9368e69b80711a226 100644 (file)
--- a/source4/torture/gpo/apply.c
+++ b/source4/torture/gpo/apply.c
@@ -61,7 +61,7 @@ static int exec_wait(struct torture_context *tctx, const char **gpo_update_cmd)
        if (!tevent_req_poll_ntstatus(req, tctx->ev, &status)) {
                return -1;
        }
-       if (!samba_runcmd_recv(req, &ret) == 0) {
+       if (samba_runcmd_recv(req, &ret) != 0) {
                return -1;
        }
        return ret;