]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
platform/x86/amd/pmf: Do not use readl() for policy buffer access
authorArmin Wolf <W_Armin@gmx.de>
Mon, 4 Mar 2024 20:50:03 +0000 (21:50 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:17:21 +0000 (18:17 -0400)
[ Upstream commit e42dddce83a0578a518cb7078930c8269a6083af ]

The policy buffer is allocated using normal memory allocation
functions, so readl() should not be used on it.

Compile-tested only.

Fixes: 7c45534afa44 ("platform/x86/amd/pmf: Add support for PMF Policy Binary")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20240304205005.10078-3-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/amd/pmf/tee-if.c

index dcbe8f85e122947be014778c14478a7374698b49..4ebfe0f5a7fb289bcee7ca5d6897c04554c67640 100644 (file)
@@ -249,8 +249,8 @@ static int amd_pmf_start_policy_engine(struct amd_pmf_dev *dev)
        u32 cookie, length;
        int res;
 
-       cookie = readl(dev->policy_buf + POLICY_COOKIE_OFFSET);
-       length = readl(dev->policy_buf + POLICY_COOKIE_LEN);
+       cookie = *(u32 *)(dev->policy_buf + POLICY_COOKIE_OFFSET);
+       length = *(u32 *)(dev->policy_buf + POLICY_COOKIE_LEN);
 
        if (cookie != POLICY_SIGN_COOKIE || !length) {
                dev_dbg(dev->dev, "cookie doesn't match\n");