]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
test: Fix a mem leak reported by Coverity
authorDavid Goulet <dgoulet@torproject.org>
Thu, 1 Jun 2023 12:35:08 +0000 (08:35 -0400)
committerDavid Goulet <dgoulet@torproject.org>
Thu, 1 Jun 2023 12:35:08 +0000 (08:35 -0400)
Here is the report:

  *** CID 1531835:  Resource leaks  (RESOURCE_LEAK)
  /src/test/test_crypto_slow.c: 683 in test_crypto_equix()
  677
  678           /* Solve phase: Make sure the test vector matches */
  679           memset(&output, 0xa5, sizeof output);
  680           equix_result result;
  681           result = equix_solve(solve_ctx, challenge_literal,
  682                                challenge_len, &output);
  >>>     CID 1531835:  Resource leaks  (RESOURCE_LEAK)
  >>>     Variable "solve_ctx" going out of scope leaks the storage it points to.

Signed-off-by: David Goulet <dgoulet@torproject.org>
src/test/test_crypto_slow.c

index 23bc7a852f2172b210b759107bbaf037b6a3cf14..3c44b8ded863621f54b3fc51893a26fe11645e6a 100644 (file)
@@ -680,6 +680,7 @@ test_crypto_equix(void *arg)
       equix_result result;
       result = equix_solve(solve_ctx, challenge_literal,
                            challenge_len, &output);
+      equix_free(solve_ctx);
       tt_int_op(result, OP_EQ, EQUIX_OK);
       tt_int_op(output.count, OP_EQ, num_sols);
       tt_int_op(output.flags, OP_EQ, sol_flags);