]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: renesas: rza1: Normalize return value of gpio_get()
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 18 Feb 2026 20:58:09 +0000 (12:58 -0800)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 10 Mar 2026 09:33:47 +0000 (10:33 +0100)
The GPIO .get() callback is expected to return 0 or 1 (or a negative
error code).  Ensure that the value returned by rza1_gpio_get() is
normalized to the [0, 1] range.

Fixes: 86ef402d805d606a ("gpiolib: sanitize the return value of gpio_chip::get()")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://patch.msgid.link/aZYnyl-Nf4S1U2yj@google.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/renesas/pinctrl-rza1.c

index bc8b9b9ad05b99910960bb7f60bb57196f3a24da..d2949e4dbaf73c70da83575de509f8d322cff720 100644 (file)
@@ -589,7 +589,7 @@ static inline unsigned int rza1_get_bit(struct rza1_port *port,
 {
        void __iomem *mem = RZA1_ADDR(port->base, reg, port->id);
 
-       return ioread16(mem) & BIT(bit);
+       return !!(ioread16(mem) & BIT(bit));
 }
 
 /**