main/refer.c: Fix double free in refer_data_destructor + potential leak

Resolves: #267

diff --git a/main/refer.c b/main/refer.c
index 11db0652fc7fa87baed177f1cd41dbb5578ac56f..2a4a1159242074231d1a53f832d69c8dbdea8b1e 100644 (file)
--- a/main/refer.c
+++ b/main/refer.c
@@ -109,7 +109,6 @@ static void refer_data_destructor(void *obj)
 {
        struct refer_data *data = obj;
        ast_free(data->value);
-       ast_free(data);
 }
 
 static void refer_destructor(void *obj)
@@ -298,6 +297,7 @@ static int refer_set_var_full(struct ast_refer *refer, const char *name, const c
                if (ast_strlen_zero(value)) {
                        ao2_unlink(refer->vars, data);
                } else {
+                       ast_free(data->value);
                        data->value = ast_strdup(value);
                }
        }