]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rtlwifi: fix memory leak for USB device
authorPeter Wu <peter@lekensteyn.nl>
Mon, 7 Dec 2015 00:07:31 +0000 (01:07 +0100)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 2 Feb 2016 17:38:33 +0000 (17:38 +0000)
commit 17bc55864f81dd730d05f09b1641312a7990d636 upstream.

Free skb for received frames with a wrong checksum. This can happen
pretty rapidly, exhausting all memory.

This fixes a memleak (detected with kmemleak). Originally found while
using monitor mode, but it also appears during managed mode (once the
link is up).

Signed-off-by: Peter Wu <peter@lekensteyn.nl>
ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
[ luis: backported to 3.16:
  - file rename: drivers/net/wireless/realtek/rtlwifi/usb.c ->
    drivers/net/wireless/rtlwifi/usb.c ]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
drivers/net/wireless/rtlwifi/usb.c

index cdd0dd7a938aa38496b1d70342755ebaa0b7f0f9..194bbe37050de16deb8f6ebdd3ad859f3ebf09b0 100644 (file)
@@ -531,6 +531,8 @@ static void _rtl_usb_rx_process_noagg(struct ieee80211_hw *hw,
                        ieee80211_rx(hw, skb);
                else
                        dev_kfree_skb_any(skb);
+       } else {
+               dev_kfree_skb_any(skb);
        }
 }