2006-06-12 Ross Burton <ross@openedhand.com>

	* glib/dbus-gproxy.c:
	Don't leak a GArray when firing signals (thank Rob Taylor for review).

diff --git a/ChangeLog b/ChangeLog
index 78c2f24c515f8cf81416c56b89829142ab2cb4ac..357b29c73fe6264b22490a9986b06975b8cf7985 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2006-06-12  Ross Burton  <ross@openedhand.com>
+
+       * glib/dbus-gproxy.c:
+       Don't leak a GArray when firing signals (thank Rob Taylor for review).
+
 2006-06-12  Thiago Macieira <thiago.macieira@trolltech.com>
 
        * Released 0.62

diff --git a/glib/dbus-gproxy.c b/glib/dbus-gproxy.c
index e422ceabc2e313620ed88432020dfc4f37286918..e424311491b5b7bec25e708137cc5788757195f4 100644 (file)
--- a/glib/dbus-gproxy.c
+++ b/glib/dbus-gproxy.c
@@ -1625,6 +1625,7 @@ dbus_g_proxy_emit_remote_signal (DBusGProxy  *proxy,
   char *name;
   GQuark q;
   DBusGProxyPrivate *priv = DBUS_G_PROXY_GET_PRIVATE(proxy);
+  GArray *msg_gsignature = NULL;
 
   g_return_if_fail (!DBUS_G_PROXY_DESTROYED (proxy));
 
@@ -1645,7 +1646,6 @@ dbus_g_proxy_emit_remote_signal (DBusGProxy  *proxy,
   if (q != 0)
     {
       GArray *gsignature;
-      GArray *msg_gsignature;
       guint i;
       
       gsignature = g_datalist_id_get_data (&priv->signal_signatures, q);
@@ -1672,6 +1672,8 @@ dbus_g_proxy_emit_remote_signal (DBusGProxy  *proxy,
 
  out:
   g_free (name);
+  if (msg_gsignature)
+    g_array_free (msg_gsignature, TRUE);
   return;
  mismatch:
 #if 0