Changed the order of arguments in make_oem_passwd_hash(). All the other

encryption functions have outputs as the last arguments.

diff --git a/source/libsmb/clirap.c b/source/libsmb/clirap.c
index c16fe2d08d37c142486cc25da9adbdee0aaa486d..c649aedfba6562a118bc2831e8b388b5cb6849dd 100644 (file)
--- a/source/libsmb/clirap.c
+++ b/source/libsmb/clirap.c
@@ -329,7 +329,7 @@ BOOL cli_oem_change_password(struct cli_state *cli, const char *user, const char
 
   clistr_push(cli, dos_new_password, new_password, -1, STR_TERMINATE);
 
-  if (!make_oem_passwd_hash( data, dos_new_password, old_pw_hash, False))
+  if (!make_oem_passwd_hash(dos_new_password, old_pw_hash, False, data))
     return False;
 
   /* 

diff --git a/source/libsmb/smbencrypt.c b/source/libsmb/smbencrypt.c
index 95d21dc772c4785f52a93b86cc88f72a8b53beba..e13b180fcb3c0689f107bdd64c315b0e6244b203 100644 (file)
--- a/source/libsmb/smbencrypt.c
+++ b/source/libsmb/smbencrypt.c
@@ -187,7 +187,8 @@ void SMBNTencrypt(uchar *passwd, uchar *c8, uchar *p24)
 #endif
 }
 
-BOOL make_oem_passwd_hash(char data[516], const char *passwd, uchar old_pw_hash[16], BOOL unicode)
+BOOL make_oem_passwd_hash(const char *passwd, uchar old_pw_hash[16], 
+                          BOOL unicode, char data[516])
 {
        int new_pw_len = strlen(passwd) * (unicode ? 2 : 1);