]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
sbuff: Typo in safecpy check
authorArran Cudbard-Bell <a.cudbardb@freeradius.org>
Fri, 31 Jul 2020 14:39:49 +0000 (10:39 -0400)
committerArran Cudbard-Bell <a.cudbardb@freeradius.org>
Fri, 31 Jul 2020 14:39:49 +0000 (10:39 -0400)
src/lib/util/sbuff.c

index 2de6bf594fb2a4e6e2656d6123275293e37abef7..7b8b5d1bc1b8289f3c627d7337665402ff1a4c6c 100644 (file)
@@ -100,7 +100,7 @@ static inline CC_HINT(always_inline) ssize_t safecpy(char *o_start, char *o_end,
        diff = (o_end - o_start) - (i_len);
        if (diff < 0) return diff;
 
-       if ((o_end < i_start) || (i_start > o_end)) {                   /* no-overlap */
+       if ((i_start > o_end) || (i_end < o_start)) {                   /* no-overlap */
                memcpy(o_start,  i_start, i_len);
        } else {                                                        /* overlap */
                memmove(o_start, i_start, i_len);