]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
path-lookup: LookupPathsFlags are a flags type, hence define it like one
authorLennart Poettering <lennart@poettering.net>
Thu, 23 Nov 2017 16:37:49 +0000 (17:37 +0100)
committerLennart Poettering <lennart@poettering.net>
Wed, 29 Nov 2017 11:34:12 +0000 (12:34 +0100)
We shouldn't rely on C's incremental assignment of values of enums for
bit fields. That'll work only between the first two flags, but for
everything following will break horrible. Hence, let's avoid any
ambiguity here, and let's clearly define the flags as shifts of 1.

src/shared/path-lookup.h

index 8ea263e473b7fdc124e049ce151484ab72003ee1..bcf9ca4de6d3a686d9afa0e29ea011fc8a7e2867 100644 (file)
@@ -28,8 +28,8 @@ typedef struct LookupPaths LookupPaths;
 #include "macro.h"
 
 typedef enum LookupPathsFlags {
-        LOOKUP_PATHS_EXCLUDE_GENERATED = 1,
-        LOOKUP_PATHS_TEMPORARY_GENERATED,
+        LOOKUP_PATHS_EXCLUDE_GENERATED   = 1 << 0,
+        LOOKUP_PATHS_TEMPORARY_GENERATED = 1 << 1,
 } LookupPathsFlags;
 
 struct LookupPaths {