]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: camss: missing error code in msm_video_register()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Dec 2020 06:51:30 +0000 (07:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Mar 2021 08:39:39 +0000 (09:39 +0100)
[ Upstream commit 9c67ed2ab299123872be14a3dc2ea44ce7e4538b ]

This error path returns success but it should return -EINVAL.

Fixes: cba3819d1e93 ("media: camss: Format configuration per hardware version")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/qcom/camss/camss-video.c

index c9bb0d023db480d1343b04ec953429996d9606a0..e81ebeb0506e48b88f691221299b474bcd4bc1e4 100644 (file)
@@ -901,6 +901,7 @@ int msm_video_register(struct camss_video *video, struct v4l2_device *v4l2_dev,
                        video->nformats = ARRAY_SIZE(formats_rdi_8x96);
                }
        } else {
+               ret = -EINVAL;
                goto error_video_register;
        }