]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/bridge: samsung-dsim: use drm_bridge_clear_and_put() to put the next bridge
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 10 Mar 2026 12:13:24 +0000 (13:13 +0100)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Fri, 20 Mar 2026 10:02:12 +0000 (11:02 +0100)
drm_bridge_clear_and_put() is simpler to write and it prevents any
potential future use-after-free.

Reviewed-by: Osama Abdelkader <osama.abdelkader@gmail.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Link: https://patch.msgid.link/20260310-drm-bridge-atomic-vs-remove-clear_and_put-v2-2-51fe222f3cf0@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/bridge/samsung-dsim.c

index ec632f26864422b50efa4b607874f3b4576ff0dd..c3eb437ef1b0b2b259adf100e49f43e9201cc2e8 100644 (file)
@@ -1988,9 +1988,7 @@ of_find_panel_or_bridge:
        return 0;
 
 err_release_next_bridge:
-       drm_bridge_put(dsi->bridge.next_bridge);
-       dsi->bridge.next_bridge = NULL;
-
+       drm_bridge_clear_and_put(&dsi->bridge.next_bridge);
        if (!(device->mode_flags & MIPI_DSI_MODE_VIDEO))
                samsung_dsim_unregister_te_irq(dsi);
 err_remove_bridge:
@@ -2007,8 +2005,7 @@ static int samsung_dsim_host_detach(struct mipi_dsi_host *host,
        if (pdata->host_ops && pdata->host_ops->detach)
                pdata->host_ops->detach(dsi, device);
 
-       drm_bridge_put(dsi->bridge.next_bridge);
-       dsi->bridge.next_bridge = NULL;
+       drm_bridge_clear_and_put(&dsi->bridge.next_bridge);
 
        samsung_dsim_unregister_te_irq(dsi);