]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
Remove "readnow" from two tests
authorTom Tromey <tom@tromey.com>
Tue, 27 Jan 2026 02:27:01 +0000 (19:27 -0700)
committerTom Tromey <tom@tromey.com>
Mon, 2 Feb 2026 20:43:09 +0000 (13:43 -0700)
These tests both claim that -readnow is needed for proper operation,
but (1) this isn't true, and (2) if it were true it would be a bug in
gdb.  So, remove the use of readnow.

Approved-by: Kevin Buettner <kevinb@redhat.com>
gdb/testsuite/gdb.dwarf2/opt-out-not-implptr.exp
gdb/testsuite/gdb.dwarf2/symtab-producer.exp

index 5057ff2c2d8089fcdfb2fca379af4dbbf5d155cc..5bfd0099b114229f628b4b2480f2c5f0cfeaf675 100644 (file)
@@ -91,12 +91,7 @@ if {[build_executable ${testfile}.exp ${testfile} \
     return -1
 }
 
-# We need --readnow because otherwise we never read in the CU we
-# created above.
-save_vars { GDBFLAGS } {
-    append set GDBFLAGS " -readnow"
-    clean_restart ${testfile}
-}
+clean_restart ${testfile}
 
 if {![runto_main]} {
     return -1
index 49bc2c25635f76ff254d9f15f64c84cd943d12ed..c90bf77518c845e0916931d0c03bd5ba22f19973 100644 (file)
@@ -71,15 +71,9 @@ Dwarf::assemble $asm_file {
     }
 }
 
-# We need --readnow because otherwise we never read in the CUs we
-# created above.
-save_vars { GDBFLAGS } {
-    set GDBFLAGS "$GDBFLAGS -readnow"
-
-    if { [prepare_for_testing "failed to prepare" ${testfile} \
-             [list $srcfile $asm_file] {nodebug}] } {
-       return -1
-    }
+if { [prepare_for_testing "failed to prepare" ${testfile} \
+         [list $srcfile $asm_file] {nodebug}] } {
+    return
 }
 
 gdb_py_test_silent_cmd "python with_producer = gdb.lookup_global_symbol(\"with_producer\")" \