]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
backlight: lm3630a: Initialize backlight_properties on init
authorLuca Weiss <luca@z3ntu.xyz>
Mon, 19 Feb 2024 23:11:19 +0000 (00:11 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:22:00 +0000 (18:22 -0400)
[ Upstream commit ad9aeb0e3aa90ebdad5fabf9c21783740eb95907 ]

The backlight_properties struct should be initialized to zero before
using, otherwise there will be some random values in the struct.

Fixes: 0c2a665a648e ("backlight: add Backlight driver for lm3630 chip")
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Link: https://lore.kernel.org/r/20240220-lm3630a-fixups-v1-1-9ca62f7e4a33@z3ntu.xyz
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/backlight/lm3630a_bl.c

index 419b0334cf0879b71aa180d59f3af8b94f934fb6..2aade66db3cf4b95d23230897af5592248d54d1c 100644 (file)
@@ -339,6 +339,7 @@ static int lm3630a_backlight_register(struct lm3630a_chip *pchip)
        struct backlight_properties props;
        const char *label;
 
+       memset(&props, 0, sizeof(struct backlight_properties));
        props.type = BACKLIGHT_RAW;
        if (pdata->leda_ctrl != LM3630A_LEDA_DISABLE) {
                props.brightness = pdata->leda_init_brt;