archive_pathmatch: Extend unit tests

Add some tests to clarify what happens in these cases. Also, this
increases test coverage.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>

diff --git a/libarchive/test/test_archive_pathmatch.c b/libarchive/test/test_archive_pathmatch.c
index 3b212aca9d94225e909a3f767fe1d133a12758cd..ee3679159727ceccbeddc1971cbbb52dd288be6c 100644 (file)
--- a/libarchive/test/test_archive_pathmatch.c
+++ b/libarchive/test/test_archive_pathmatch.c
@@ -56,6 +56,10 @@ DEFINE_TEST(test_archive_pathmatch)
        assertEqualInt(0, archive_pathmatch_w(L"a/b/c", NULL, 0));
 
        /* Empty pattern only matches empty string. */
+       assertEqualInt(1, archive_pathmatch(NULL,NULL, 0));
+       assertEqualInt(1, archive_pathmatch(NULL,"", 0));
+       assertEqualInt(0, archive_pathmatch(NULL,"a", 0));
+       assertEqualInt(1, archive_pathmatch("",NULL, 0));
        assertEqualInt(1, archive_pathmatch("","", 0));
        assertEqualInt(0, archive_pathmatch("","a", 0));
        assertEqualInt(1, archive_pathmatch("*","", 0));
@@ -76,11 +80,15 @@ DEFINE_TEST(test_archive_pathmatch)
        assertEqualInt(0, archive_pathmatch("a", "ab", 0));
        assertEqualInt(0, archive_pathmatch("a", "ab", 0));
        assertEqualInt(1, archive_pathmatch("a?c", "abc", 0));
+       assertEqualInt(1, archive_pathmatch("*a", "/a", 0));
+       assertEqualInt(1, archive_pathmatch("*a", "a", 0));
        /* SUSv2: ? matches / */
        assertEqualInt(1, archive_pathmatch("a?c", "a/c", 0));
        assertEqualInt(1, archive_pathmatch("a?*c*", "a/c", 0));
        assertEqualInt(1, archive_pathmatch("*a*", "a/c", 0));
        assertEqualInt(1, archive_pathmatch("*a*", "/a/c", 0));
+       assertEqualInt(0, archive_pathmatch("*a", "/a/c", 0));
+       assertEqualInt(0, archive_pathmatch("*a", "a/c", 0));
        assertEqualInt(1, archive_pathmatch("*a*", "defaaaaaaa", 0));
        assertEqualInt(0, archive_pathmatch("a*", "defghi", 0));
        assertEqualInt(0, archive_pathmatch("*a*", "defghi", 0));