Move the unlock of the spyee channel to outside the start_spying() function so that

the channel is not unlocked twice when using whisper mode.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114662 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/apps/app_chanspy.c b/apps/app_chanspy.c
index 159fdb954b336700527a2ec853e926316d0d09e2..b58b6d1ef4e7336493df22fc019102e5f7cc230a 100644 (file)
--- a/apps/app_chanspy.c
+++ b/apps/app_chanspy.c
@@ -208,12 +208,9 @@ static int start_spying(struct ast_channel *chan, const char *spychan_name, stru
 
        res = ast_audiohook_attach(chan, audiohook);
 
-       if (!res && ast_test_flag(chan, AST_FLAG_NBRIDGE) && (peer = ast_bridged_channel(chan))) {
-               ast_channel_unlock(chan);
+       if (!res && ast_test_flag(chan, AST_FLAG_NBRIDGE) && (peer = ast_bridged_channel(chan))) { 
                ast_softhangup(peer, AST_SOFTHANGUP_UNBRIDGE);  
-       } else
-               ast_channel_unlock(chan);
-
+       }
        return res;
 }
 
@@ -263,16 +260,18 @@ static int channel_spy(struct ast_channel *chan, struct chanspy_ds *spyee_chansp
        
        ast_audiohook_init(&csth.spy_audiohook, AST_AUDIOHOOK_TYPE_SPY, "ChanSpy");
 
-       if (start_spying(spyee, spyer_name, &csth.spy_audiohook)) { /* Unlocks spyee */
+       if (start_spying(spyee, spyer_name, &csth.spy_audiohook)) {
                ast_audiohook_destroy(&csth.spy_audiohook);
+               ast_channel_unlock(spyee);
                return 0;
        }
        
        if (ast_test_flag(flags, OPTION_WHISPER)) {
                ast_audiohook_init(&csth.whisper_audiohook, AST_AUDIOHOOK_TYPE_WHISPER, "ChanSpy");
-               start_spying(spyee, spyer_name, &csth.whisper_audiohook); /* Unlocks spyee */
+               start_spying(spyee, spyer_name, &csth.whisper_audiohook);
        }
 
+       ast_channel_unlock(spyee);
        spyee = NULL;
 
        csth.volfactor = *volfactor;