]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
netfilter: nf_tables: do not compare internal table flags on updates
authorPablo Neira Ayuso <pablo@netfilter.org>
Thu, 14 Mar 2024 17:51:38 +0000 (18:51 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:22:04 +0000 (18:22 -0400)
[ Upstream commit 4a0e7f2decbf9bd72461226f1f5f7dcc4b08f139 ]

Restore skipping transaction if table update does not modify flags.

Fixes: 179d9ba5559a ("netfilter: nf_tables: fix table flag updates")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/nf_tables_api.c

index 73b0a6925304c9bdb7169c028375b23cb08c68e5..8d4472b127e41c8d75850a705010bd21c4f5b828 100644 (file)
@@ -1097,7 +1097,7 @@ static int nf_tables_updtable(struct nft_ctx *ctx)
        if (flags & ~NFT_TABLE_F_DORMANT)
                return -EINVAL;
 
-       if (flags == ctx->table->flags)
+       if (flags == (ctx->table->flags & NFT_TABLE_F_MASK))
                return 0;
 
        /* No dormant off/on/off/on games in single transaction */