]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: ethernet: renesas: rcar_gen4_ptp: Use lockdep to verify internal usage
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Mon, 8 Sep 2025 15:44:26 +0000 (17:44 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 12 Sep 2025 01:34:34 +0000 (18:34 -0700)
Instead of a having a comment that the lock must be held when calling
the internal helper add a lockdep check to enforce it.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250908154426.3062861-4-niklas.soderlund+renesas@ragnatech.se
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/renesas/rcar_gen4_ptp.c

index cf13eba9b65e14076b26c8c087947399a7895a3a..d0979abd36de4a1d190f46fee6803ae14c9468eb 100644 (file)
@@ -42,12 +42,13 @@ static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
        return 0;
 }
 
-/* Caller must hold the lock */
 static void _rcar_gen4_ptp_gettime(struct ptp_clock_info *ptp,
                                   struct timespec64 *ts)
 {
        struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp);
 
+       lockdep_assert_held(&ptp_priv->lock);
+
        ts->tv_nsec = ioread32(ptp_priv->addr + PTPGPTPTM00_REG);
        ts->tv_sec = ioread32(ptp_priv->addr + PTPGPTPTM10_REG) |
                     ((s64)ioread32(ptp_priv->addr + PTPGPTPTM20_REG) << 32);