fix flow deadlock issue in detection engine state introduced by tx api.

Issue discovered by coverity.

diff --git a/src/detect-engine-state.c b/src/detect-engine-state.c
index a6fc7a994868b89491cf2daf044c2da6143e3ff3..f8b8ce854bc707d7b8ec14d4910426cee991b671 100644 (file)
--- a/src/detect-engine-state.c
+++ b/src/detect-engine-state.c
@@ -665,13 +665,13 @@ int DeStateDetectContinueDetection(ThreadVars *tv, DetectEngineCtx *de_ctx, Dete
                 if (htp_state->connp == NULL || htp_state->connp->conn == NULL) {
                     SCLogDebug("HTP state has no conn(p)");
                     FLOWLOCK_UNLOCK(f);
-                    SCReturnInt(0);
+                    goto end;
                 }
 
                 int tx_id = AppLayerTransactionGetInspectId(f);
                 if (tx_id == -1) {
                     FLOWLOCK_UNLOCK(f);
-                    SCReturnInt(0);
+                    goto end;
                 }
 
                 int total_txs = (int)list_size(htp_state->connp->conn->transactions);