clk: airoha: fix off-by-one in clock ID boundary check

The boundary checks in airoha_clk_enable(), airoha_clk_get_rate(), and
airoha_clk_set_rate() use "id > data->num_clocks" which allows id equal
to num_clocks to pass. Since data->descs[] has exactly num_clocks entries
(indices 0 to num_clocks-1), id=num_clocks results in an out-of-bounds
array access.

This is currently not triggered because the device tree clock IDs are
within bounds, but the check should be defensive. Fix by changing the
comparison from ">" to ">=".

Fixes: d0b81afb5ec9 ("clk: airoha: Add support for Airoha AN7581 SoC clock")
Signed-off-by: Wayen Yan <win847@gmail.com>

diff --git a/drivers/clk/airoha/clk-airoha.c b/drivers/clk/airoha/clk-airoha.c
index 49dbca8213550ff31a97f73b4d2c86abf3c1b16d..89a8b4cb1cf8af2d39386a8d11c4d4f73fd1e8db 100644 (file)
--- a/drivers/clk/airoha/clk-airoha.c
+++ b/drivers/clk/airoha/clk-airoha.c
@@ -327,7 +327,7 @@ static int airoha_clk_enable(struct clk *clk)
        struct airoha_clk_soc_data *data = priv->data;
        int id = clk->id;
 
-       if (id > data->num_clocks)
+       if (id >= data->num_clocks)
                return -EINVAL;
 
        return 0;
@@ -349,7 +349,7 @@ static ulong airoha_clk_get_rate(struct clk *clk)
        ulong rate;
        int ret;
 
-       if (id > data->num_clocks) {
+       if (id >= data->num_clocks) {
                dev_err(clk->dev, "Invalid clk ID %d\n", id);
                return 0;
        }
@@ -412,7 +412,7 @@ static ulong airoha_clk_set_rate(struct clk *clk, ulong rate)
        int div;
        int ret;
 
-       if (id > data->num_clocks) {
+       if (id >= data->num_clocks) {
                dev_err(clk->dev, "Invalid clk ID %d\n", id);
                return 0;
        }