]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[2480] avoid redundant text dump of RRSIGs in pullSigs().
authorJINMEI Tatuya <jinmei@isc.org>
Sat, 22 Dec 2012 19:00:40 +0000 (11:00 -0800)
committerJINMEI Tatuya <jinmei@isc.org>
Sat, 22 Dec 2012 19:06:49 +0000 (11:06 -0800)
now that RRset::toText() includes RRSIGs, the additional toText() is not
necessary; in fact, that would lead to confusing output from failed tests.

src/lib/testutils/dnsmessage_test.h

index 262d1778fea7c4f8c13447b67f71d0e33c40df6a..6de01ec86a71ca271932aa81f4ba663523aa926c 100644 (file)
@@ -208,10 +208,9 @@ pullSigs(std::vector<isc::dns::ConstRRsetPtr>& rrsets,
 {
     for (ITERATOR it = begin; it != end; ++it) {
         rrsets.push_back(*it);
-        text += (*it)->toText();
+        text += (*it)->toText(); // this will include RRSIG, if attached.
         if ((*it)->getRRsig()) {
             rrsets.push_back((*it)->getRRsig());
-            text += (*it)->getRRsig()->toText();
         }
     }
 }