]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amdkfd: Fix Unchecked Return Value
authorSunday Clement <Sunday.Clement@amd.com>
Fri, 17 Oct 2025 14:15:50 +0000 (10:15 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 28 Oct 2025 14:10:23 +0000 (10:10 -0400)
Properly check the return values for function, as done elsewhere.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
Reviewed-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c

index 6e7bc983fc0b681ca621a82d2848b1ba32568980..4fbe865ff27967d95810ab5328f9524adf22fc26 100644 (file)
@@ -1897,6 +1897,8 @@ fail_packet_manager_init:
 
 static int stop_cpsch(struct device_queue_manager *dqm)
 {
+       int ret = 0;
+
        dqm_lock(dqm);
        if (!dqm->sched_running) {
                dqm_unlock(dqm);
@@ -1904,9 +1906,10 @@ static int stop_cpsch(struct device_queue_manager *dqm)
        }
 
        if (!dqm->dev->kfd->shared_resources.enable_mes)
-               unmap_queues_cpsch(dqm, KFD_UNMAP_QUEUES_FILTER_ALL_QUEUES, 0, USE_DEFAULT_GRACE_PERIOD, false);
+               ret = unmap_queues_cpsch(dqm, KFD_UNMAP_QUEUES_FILTER_ALL_QUEUES,
+                                                               0, USE_DEFAULT_GRACE_PERIOD, false);
        else
-               remove_all_kfd_queues_mes(dqm);
+               ret = remove_all_kfd_queues_mes(dqm);
 
        dqm->sched_running = false;
 
@@ -1920,7 +1923,7 @@ static int stop_cpsch(struct device_queue_manager *dqm)
        dqm->detect_hang_info = NULL;
        dqm_unlock(dqm);
 
-       return 0;
+       return ret;
 }
 
 static int create_kernel_queue_cpsch(struct device_queue_manager *dqm,