]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
usb: host: ehci-msm: Fix pointer check
authorStephan Gerhold <stephan.gerhold@linaro.org>
Mon, 7 Apr 2025 09:54:21 +0000 (11:54 +0200)
committerTom Rini <trini@konsulko.com>
Thu, 30 Oct 2025 17:04:51 +0000 (11:04 -0600)
dev_read_addr_ptr() returns a null pointer on error, not FDT_ADDR_T_NONE.

Fixes: 2be1130a9305 ("usb: ehci-msm: Use dev interface to get device address")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
Acked-by: Caleb Connolly <caleb.connolly@linaro.org>
Tested-by: Sam Day <me@samcday.com>
Link: https://patch.msgid.link/20250407-ehci-msm-fixes-v1-1-f8b30eb05d07@linaro.org
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
drivers/usb/host/ehci-msm.c

index a759aea9db38dd5af2bb85b677ac403018983cfb..dd1d527a3a2c3f38df747dbb41cbb84bf76286e2 100644 (file)
@@ -141,7 +141,7 @@ static int ehci_usb_of_to_plat(struct udevice *dev)
        priv->ulpi_vp.port_num = 0;
        priv->ehci = dev_read_addr_ptr(dev);
 
-       if (priv->ehci == (void *)FDT_ADDR_T_NONE)
+       if (!priv->ehci)
                return -EINVAL;
 
        /* Warning: this will not work if viewport address is > 64 bit due to