]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
clean up the dialect selection thing here
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 4 Jun 2013 22:49:24 +0000 (18:49 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 4 Jun 2013 22:49:24 +0000 (18:49 -0400)
lib/sqlalchemy/testing/assertions.py

index 59246730252fc229e1676b01ade53c1c42c87c8a..96a8bc0237812b5f8e30b4e6be986bfff7d76dd1 100644 (file)
@@ -184,15 +184,19 @@ class AssertsCompiledSQL(object):
                         allow_dialect_select=False):
         if use_default_dialect:
             dialect = default.DefaultDialect()
-        elif dialect == None and not allow_dialect_select:
-            dialect = getattr(self, '__dialect__', None)
+        elif allow_dialect_select:
+            dialect = None
+        else:
+            if dialect is None:
+                dialect = getattr(self, '__dialect__', None)
+
+            if dialect is None:
+                dialect = config.db.dialect
+            elif dialect == 'default':
+                dialect = default.DefaultDialect()
+            elif isinstance(dialect, util.string_types):
+                dialect = create_engine("%s://" % dialect).dialect
 
-        if dialect == 'default':
-            dialect = default.DefaultDialect()
-        elif dialect is None:
-            dialect = config.db.dialect
-        elif isinstance(dialect, util.string_types):
-            dialect = create_engine("%s://" % dialect).dialect
 
         kw = {}
         if params is not None: