]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: lan78xx: fix transfer-buffer memory leak
authorJohan Hovold <johan@kernel.org>
Tue, 28 Jul 2020 12:10:30 +0000 (14:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Aug 2020 08:06:03 +0000 (10:06 +0200)
[ Upstream commit 63634aa679ba8b5e306ad0727120309ae6ba8a8e ]

The interrupt URB transfer-buffer was never freed on disconnect or after
probe errors.

Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")
Cc: Woojung.Huh@microchip.com <Woojung.Huh@microchip.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/usb/lan78xx.c

index 2dff233814ea5bef82ff07b1d8ddb4c1e036d64b..d198f36785a465398237c952f75a8c592d767159 100644 (file)
@@ -3815,6 +3815,7 @@ static int lan78xx_probe(struct usb_interface *intf,
                        usb_fill_int_urb(dev->urb_intr, dev->udev,
                                         dev->pipe_intr, buf, maxp,
                                         intr_complete, dev, period);
+                       dev->urb_intr->transfer_flags |= URB_FREE_BUFFER;
                }
        }