]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
pid1: shorten message about jobs skipped after failed condition checks
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 4 Feb 2026 09:21:43 +0000 (10:21 +0100)
committerLuca Boccassi <luca.boccassi@gmail.com>
Fri, 27 Feb 2026 20:05:57 +0000 (20:05 +0000)
I was looking at some logs on a console, and because of the lengthy message,
the actually interesting part, i.e. what condition failed, didn't even fit
on the screen. Let's make the sentence legible but brief.

(cherry picked from commit 7a1e761070e5b223191b1cb7526730adf1a76681)
(cherry picked from commit 35e25d52653cd112482df605fc9f9bd8f0cbbe59)
(cherry picked from commit 07c1b0a86d343d868cdca02dc89e200418f2ce21)

src/core/job.c

index c6c736cc6f86a52aaae960820326b66a09dade4d..c0db44f817edaa336948e22f13d7b576b96608bf 100644 (file)
@@ -790,7 +790,7 @@ static void job_emit_done_message(Unit *u, uint32_t job_id, JobType t, JobResult
                                 log_unit_struct(
                                         u,
                                         job_done_messages[result].log_level,
-                                        LOG_MESSAGE("%s was skipped because no trigger condition checks were met.",
+                                        LOG_MESSAGE("%s skipped, no trigger condition checks were met.",
                                                     ident),
                                         "JOB_ID=%" PRIu32, job_id,
                                         "JOB_TYPE=%s", job_type_to_string(t),
@@ -801,7 +801,7 @@ static void job_emit_done_message(Unit *u, uint32_t job_id, JobType t, JobResult
                                 log_unit_struct(
                                         u,
                                         job_done_messages[result].log_level,
-                                        LOG_MESSAGE("%s was skipped because of an unmet condition check (%s=%s%s).",
+                                        LOG_MESSAGE("%s skipped, unmet condition check %s=%s%s",
                                                     ident,
                                                     condition_type_to_string(c->type),
                                                     c->negate ? "!" : "",