]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
fixup simplify the url parser more bagder/smtp-strparse 19270/head
authorDaniel Stenberg <daniel@haxx.se>
Tue, 28 Oct 2025 15:19:10 +0000 (16:19 +0100)
committerDaniel Stenberg <daniel@haxx.se>
Tue, 28 Oct 2025 15:19:10 +0000 (16:19 +0100)
lib/smtp.c

index d722ba8f1071bef014a3d63a79adec0659fcaf09..8b199d2ea3efe69c874c805f1b46bd2d334b2b9c 100644 (file)
@@ -1754,6 +1754,7 @@ static CURLcode smtp_parse_url_options(struct connectdata *conn,
 
   while(!result && ptr && *ptr) {
     struct Curl_str key;
+    result = CURLE_URL_MALFORMAT;
     if(!curlx_str_until(&ptr, &key, 64, '=') &&
        !curlx_str_single(&ptr, '=')) {
       struct Curl_str value;
@@ -1765,13 +1766,9 @@ static CURLcode smtp_parse_url_options(struct connectdata *conn,
         result = Curl_sasl_parse_url_auth_option(&smtpc->sasl,
                                                  curlx_str(&value),
                                                  curlx_strlen(&value));
-      else
-        result = CURLE_URL_MALFORMAT;
       if(!semi)
         break;
     }
-    else
-      result = CURLE_URL_MALFORMAT;
   }
 
   return result;