DTLS1.3: Disable tests that currently fail

With added TODO(DTLSv1.3) comments

Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28455)

diff --git a/test/dtlstest.c b/test/dtlstest.c
index c8bf5125f438a12201efb40944c3fea7dfd1aeb4..dce8990b737819e285011a3da47c9bbce48bd936 100644 (file)
--- a/test/dtlstest.c
+++ b/test/dtlstest.c
@@ -616,9 +616,11 @@ static int test_duplicate_app_data(void)
     char buf[10];
     int ret;
 
+/* TODO(DTLS-1.3): This test does not work properly with DTLS-1.3. */
+
     if (!TEST_true(create_ssl_ctx_pair(NULL, DTLS_server_method(),
                                        DTLS_client_method(),
-                                       DTLS1_VERSION, 0,
+                                       DTLS1_VERSION, DTLS1_2_VERSION,
                                        &sctx, &cctx, cert, privkey)))
         return 0;
 

diff --git a/test/recipes/70-test_tls13certcomp.t b/test/recipes/70-test_tls13certcomp.t
index 19a0bbdb7571e6868d06ef467d559adb81f6d2a4..c718c503df13c3fb8351f0152eee57c9f71c93e5 100644 (file)
--- a/test/recipes/70-test_tls13certcomp.t
+++ b/test/recipes/70-test_tls13certcomp.t
@@ -220,6 +220,8 @@ SKIP: {
 }
 
 SKIP: {
+    # TODO(DTLSv1.3): This test currently does not work for DTLS.
+    skip "Test does not work correctly currently", $testcount;
     skip "DTLS 1.3 is disabled", $testcount if disabled("dtls1_3");
     skip "DTLSProxy does not work on Windows", $testcount if $^O =~ /^(MSWin32)$/;
     run_tests(1);

diff --git a/test/recipes/70-test_tls13cookie.t b/test/recipes/70-test_tls13cookie.t
index 2faeec8784d6b097ce59d487314921220cf8521e..a2edc106976dca8a51e1b171a89b645985651586 100644 (file)
--- a/test/recipes/70-test_tls13cookie.t
+++ b/test/recipes/70-test_tls13cookie.t
@@ -40,6 +40,9 @@ SKIP: {
 }
 
 SKIP: {
+    # TODO(DTLSv1.3): This test currently does not work for DTLS. It gets stuck
+    # in the first test case.
+    skip "Test does not work correctly currently", $testcount;
     skip "DTLS 1.3 is disabled", $testcount if disabled("dtls1_3");
     skip "DTLSProxy does not work on Windows", $testcount if $^O =~ /^(MSWin32)$/;
     run_tests(1);

diff --git a/test/recipes/70-test_tls13downgrade.t b/test/recipes/70-test_tls13downgrade.t
index 96827b61fadcb8b3aa1fad6a35f931a403042bf8..bc812ae6c1a4b8ddad16e0be5e396045b462e04b 100644 (file)
--- a/test/recipes/70-test_tls13downgrade.t
+++ b/test/recipes/70-test_tls13downgrade.t
@@ -50,6 +50,10 @@ SKIP: {
 }
 
 SKIP: {
+    # TODO(DTLSv1.3): This test currently does not work for DTLS. It gets stuck
+    # in the first test case.
+    skip "Test does not work correctly currently", $testcount;
+
     skip "DTLS 1.2 or 1.3 is disabled", $testcount if disabled("dtls1_3")
                                                       || disabled("dtls1_2");
     skip "DTLSProxy does not work on Windows", $testcount if $^O =~ /^(MSWin32)$/;

diff --git a/test/recipes/70-test_tls13hrr.t b/test/recipes/70-test_tls13hrr.t
index ffe4b3fc7a9c20cc63b4a99c358bab64f1a778b1..277ad565161c59af4bfc50ac5eb572de9728efc6 100644 (file)
--- a/test/recipes/70-test_tls13hrr.t
+++ b/test/recipes/70-test_tls13hrr.t
@@ -52,6 +52,10 @@ SKIP: {
 }
 
 SKIP: {
+    # TODO(DTLSv1.3): This test currently does not work for DTLS. It gets stuck
+    # in the first test case.
+    skip "Test does not work correctly currently with DTLS-1.3", $testcount;
+
     skip "DTLS 1.3 is disabled", $testcount if disabled("dtls1_3");
     skip "DTLSProxy does not work on Windows", $testcount if $^O =~ /^(MSWin32)$/;
     run_tests(1);

diff --git a/test/recipes/70-test_tls13messages.t b/test/recipes/70-test_tls13messages.t
index 282c88d848e96340bd335b506a9cf1780965f0b6..7373345bca795b385f8344a6a808e6e7c330b85c 100644 (file)
--- a/test/recipes/70-test_tls13messages.t
+++ b/test/recipes/70-test_tls13messages.t
@@ -210,6 +210,10 @@ SKIP: {
 }
 
 SKIP: {
+    # TODO(DTLSv1.3): This test currently does not work for DTLS. It fails
+    # checking the extensions for ENCRYPTED_EXTENSIONS message type.
+    skip "Test does not work correctly currently", $testcount;
+
     skip "DTLS 1.3 is disabled", $testcount if disabled("dtls1_3");
     skip "DTLSProxy does not work on Windows", $testcount if $^O =~ /^(MSWin32)$/;
     run_tests(1);