]> git.ipfire.org Git - thirdparty/libarchive.git/commitdiff
Fix signed-unsigned comparison in add_trivial_nfs4_acl 2766/head
authorMostyn Bramley-Moore <mostyn@antipode.se>
Thu, 30 Oct 2025 10:29:55 +0000 (11:29 +0100)
committerMostyn Bramley-Moore <mostyn@antipode.se>
Thu, 30 Oct 2025 10:29:55 +0000 (11:29 +0100)
Resolves #2760

libarchive/archive_disk_acl_darwin.c

index 12c3587c53b70363f6eab052665e2383c1871e11..b4842d184866ea5f6e3207a5492e94f53165b7c4 100644 (file)
@@ -124,7 +124,6 @@ static void
 add_trivial_nfs4_acl(struct archive_entry *entry)
 {
        mode_t mode;
-       int i;
        const int rperm = ARCHIVE_ENTRY_ACL_READ_DATA;
        const int wperm = ARCHIVE_ENTRY_ACL_WRITE_DATA |
            ARCHIVE_ENTRY_ACL_APPEND_DATA;
@@ -195,7 +194,7 @@ add_trivial_nfs4_acl(struct archive_entry *entry)
        } else if ((mode & 0010) || (mode & 0001))
                tacl_entry[1].permset |= eperm;
 
-       for (i = 0; i < sizeof(tacl_entry) / sizeof(tacl_entry[0]); i++) {
+       for (size_t i = 0; i < sizeof(tacl_entry) / sizeof(tacl_entry[0]); i++) {
                if (tacl_entry[i].permset != 0) {
                        archive_entry_acl_add_entry(entry,
                            tacl_entry[i].type, tacl_entry[i].permset,