execute: Do not alter call-by-ref parameter on failure

Prevent free from being called on (a part of) the call-by-reference
variable env when setup_pam fails.

diff --git a/src/core/execute.c b/src/core/execute.c
index 1a7620b0848c56882c7103260d8dccfb93fb3ba8..8c487b371f94a12263ef16934d05598af0b36933 100644 (file)
--- a/src/core/execute.c
+++ b/src/core/execute.c
@@ -835,7 +835,7 @@ static int setup_pam(
         pam_handle_t *handle = NULL;
         sigset_t old_ss;
         int pam_code = PAM_SUCCESS, r;
-        char **e = NULL;
+        char **nv, **e = NULL;
         bool close_session = false;
         pid_t pam_pid = 0, parent_pid;
         int flags = 0;
@@ -870,8 +870,8 @@ static int setup_pam(
                         goto fail;
         }
 
-        STRV_FOREACH(e, *env) {
-                pam_code = pam_putenv(handle, *e);
+        STRV_FOREACH(nv, *env) {
+                pam_code = pam_putenv(handle, *nv);
                 if (pam_code != PAM_SUCCESS)
                         goto fail;
         }