]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
coredump: add note about lack of rollback on oom 4526/head
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 16 Jan 2017 01:25:35 +0000 (20:25 -0500)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 15 Feb 2017 05:45:43 +0000 (00:45 -0500)
src/coredump/coredump.c

index 7b11e230bfef41bee7de235a3417d1757e0fbd27..1bb1dbbe8d97178b96f7efeb536211e8108c776a 100644 (file)
@@ -1049,7 +1049,9 @@ static int gather_pid_metadata(
                 char **comm_fallback,
                 char **comm_ret,
                 struct iovec *iovec, size_t *n_iovec) {
-        /* We need 25 empty slots in iovec! */
+        /* We need 25 empty slots in iovec!
+         * Note that if we fail on oom later on, we do not roll-back changes to the iovec
+         * structure. (It remains valid, with the first n_iovec fields initialized.) */
 
         _cleanup_free_ char *exe = NULL, *comm = NULL;
         uid_t owner_uid;