]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
firstboot: do not write vconsole.conf when arg_keymap is empty 7449/head
authorYu Watanabe <watanabe.yu+github@gmail.com>
Sat, 25 Nov 2017 10:11:57 +0000 (19:11 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Sat, 25 Nov 2017 10:11:57 +0000 (19:11 +0900)
src/firstboot/firstboot.c

index afbfa3743d6453ee66b60e668ac5af21f8104f0e..207ddeb70f11ec17178073698ee9e431167403b8 100644 (file)
@@ -346,13 +346,15 @@ static int process_keymap(void) {
         if (r < 0)
                 return r;
 
-        if (!isempty(arg_keymap))
-                keymap = STRV_MAKE(strjoina("KEYMAP=", arg_keymap));
-
-        if (!keymap)
+        if (isempty(arg_keymap))
                 return 0;
 
-        mkdir_parents(etc_vconsoleconf, 0755);
+        keymap = STRV_MAKE(strjoina("KEYMAP=", arg_keymap));
+
+        r = mkdir_parents(etc_vconsoleconf, 0755);
+        if (r < 0)
+                return log_error_errno(r, "Failed to create the parent directory of %s: %m", etc_vconsoleconf);
+
         r = write_env_file(etc_vconsoleconf, keymap);
         if (r < 0)
                 return log_error_errno(r, "Failed to write %s: %m", etc_vconsoleconf);