From: JINMEI Tatuya <jinmei@isc.org>
Date: Fri, 1 Jun 2012 20:58:24 +0000 (-0700)
Subject: [1912] add another test case where DS somehow exists under a cut and is asked.
X-Git-Tag: trac2351_base~226^2~60^2^2~4^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0010be465624ebd2c72aa41e9a56935e76f3da5c;p=thirdparty%2Fkea.git

[1912] add another test case where DS somehow exists under a cut and is asked.

just confirming the behavior; the implementation should already handle this
case correctly.
---

diff --git a/src/lib/datasrc/tests/database_unittest.cc b/src/lib/datasrc/tests/database_unittest.cc
index 2251c49ff5..55d8052653 100644
--- a/src/lib/datasrc/tests/database_unittest.cc
+++ b/src/lib/datasrc/tests/database_unittest.cc
@@ -162,6 +162,11 @@ const char* const TEST_RECORDS[][5] = {
     {"insecdelegation.example.org.", "NS", "3600", "", "ns.example.com."},
     {"insecdelegation.example.org.", "NSEC", "3600", "",
      "dummy.example.org. NS NSEC"},
+    // and a DS under the zone cut. Such an RR shouldn't exist in a sane zone,
+    // but it could by error or some malicious attempt.  It shouldn't confuse
+    // the implementation)
+    {"child.insecdelegation.example.org.", "DS", "3600", "", "DS 5 3 3600 "
+     "20000101000000 20000201000000 12345 example.org. FAKEFAKEFAKE"},
 
     // Broken NS
     {"brokenns1.example.org.", "A", "3600", "", "192.0.2.1"},
@@ -2238,6 +2243,16 @@ TYPED_TEST(DatabaseClientTest, findDS) {
                this->expected_rdatas_, this->expected_sig_rdatas_,
                ZoneFinder::RESULT_NSEC_SIGNED,
                Name("insecdelegation.example.org."), ZoneFinder::FIND_DNSSEC);
+
+    // Some insane case: DS under a zone cut.  It's included in the DB, but
+    // shouldn't be visible via finder.
+    this->expected_rdatas_.clear();
+    this->expected_rdatas_.push_back("ns.example.com");
+    doFindTest(*finder, Name("child.insecdelegation.example.org"),
+               RRType::DS(), RRType::NS(), this->rrttl_,
+               ZoneFinder::DELEGATION, this->expected_rdatas_,
+               this->empty_rdatas_, ZoneFinder::RESULT_DEFAULT,
+               Name("insecdelegation.example.org."), ZoneFinder::FIND_DNSSEC);
 }
 
 TYPED_TEST(DatabaseClientTest, emptyDomain) {