From: Nick Mathewson <nickm@torproject.org>
Date: Sun, 2 Dec 2018 01:46:06 +0000 (-0500)
Subject: Use tor_strdup() in place of malloc+strncpy+terminate.
X-Git-Tag: tor-0.4.0.1-alpha~104
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0015d0084262ddc60098b15d6cdf30ea66d59a53;p=thirdparty%2Ftor.git

Use tor_strdup() in place of malloc+strncpy+terminate.
---

diff --git a/src/tools/tor-resolve.c b/src/tools/tor-resolve.c
index ba83f3e3b4..803ed26b3b 100644
--- a/src/tools/tor-resolve.c
+++ b/src/tools/tor-resolve.c
@@ -512,14 +512,7 @@ do_resolve(const char *hostname,
       domainname_t *dn =
         socks5_server_reply_get_bind_addr_domainname(reply);
 
-      size_t result_len = (size_t)domainname_get_len(dn);
-
-      *result_hostname = tor_malloc(result_len+1);
-
-      strncpy(*result_hostname, (char *)domainname_getstr_name(dn),
-              result_len);
-
-      (*result_hostname)[result_len] = '\0';
+      *result_hostname = tor_strdup(domainname_getstr_name(dn));
     }
 
     socks5_server_reply_free(reply);