From: Stefan Metzmacher Date: Tue, 8 Sep 2020 10:13:20 +0000 (+0000) Subject: lib/replace: move lib/replace/closefrom.c from ROKEN_HOSTCC_SOURCE to REPLACE_HOSTCC_... X-Git-Tag: talloc-2.3.2~571 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0022cd94587b805a525b0b9ef71ff0f15780424a;p=thirdparty%2Fsamba.git lib/replace: move lib/replace/closefrom.c from ROKEN_HOSTCC_SOURCE to REPLACE_HOSTCC_SOURCE This is where it really belongs and we avoid the strange interaction with source4/heimdal_build/config.h. This a follow up for commit f31333d40e6fa38daa32a3ebb32d5a317c06fc62. This fixes a build problem if libbsd-dev is not installed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14482 Signed-off-by: Stefan Metzmacher Reviewed-by: Alexander Bokovoy Reviewed-by: Andreas Schneider Reviewed-by: Björn Jacke Autobuild-User(master): Stefan Metzmacher Autobuild-Date(master): Tue Sep 8 13:59:58 UTC 2020 on sn-devel-184 --- diff --git a/lib/replace/wscript b/lib/replace/wscript index 25461153749..85bc11d2f01 100644 --- a/lib/replace/wscript +++ b/lib/replace/wscript @@ -874,6 +874,9 @@ def build(bld): if bld.CONFIG_SET('HAVE_LIBRT'): extra_libs += ' rt' if bld.CONFIG_SET('REPLACE_REQUIRES_LIBSOCKET_LIBNSL'): extra_libs += ' socket nsl' + if not bld.CONFIG_SET('HAVE_CLOSEFROM'): + REPLACE_HOSTCC_SOURCE += ' closefrom.c' + bld.SAMBA_SUBSYSTEM('LIBREPLACE_HOSTCC', REPLACE_HOSTCC_SOURCE, use_hostcc=True, diff --git a/source4/heimdal_build/wscript_build b/source4/heimdal_build/wscript_build index f7ff33160ca..09c525c2957 100644 --- a/source4/heimdal_build/wscript_build +++ b/source4/heimdal_build/wscript_build @@ -391,12 +391,7 @@ if not bld.CONFIG_SET('USING_SYSTEM_ROKEN'): ../heimdal_build/replace.c ''' - if not bld.CONFIG_SET('HAVE_CLOSEFROM'): - ROKEN_HOSTCC_SOURCE = ROKEN_COMMON_SOURCE + ''' - ../../lib/replace/closefrom.c - ''' - else: - ROKEN_HOSTCC_SOURCE = ROKEN_COMMON_SOURCE + ROKEN_HOSTCC_SOURCE = ROKEN_COMMON_SOURCE ROKEN_SOURCE = ROKEN_COMMON_SOURCE + ''' lib/roken/resolve.c