From: Andreas Schneider Date: Mon, 15 Feb 2016 07:27:54 +0000 (+0100) Subject: sdb: Fix NULL pointer deference if we return early X-Git-Tag: tdb-1.3.10~1013 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=00267c9565fc82b930f6292a51234580eba4ae89;p=thirdparty%2Fsamba.git sdb: Fix NULL pointer deference if we return early If we return because of a wrong realm in a cross forest trust case, we do not have a skdc_entry allocated. Signed-off-by: Andreas Schneider Reviewed-by: Alexander Bokovoy --- diff --git a/source4/kdc/sdb_to_kdb.c b/source4/kdc/sdb_to_kdb.c index ce05b626633..d842052117e 100644 --- a/source4/kdc/sdb_to_kdb.c +++ b/source4/kdc/sdb_to_kdb.c @@ -331,11 +331,14 @@ int sdb_entry_ex_to_kdb_entry_ex(krb5_context context, ZERO_STRUCTP(k); - skdc_entry = talloc_get_type(s->ctx, struct samba_kdc_entry); + if (s->ctx != NULL) { + skdc_entry = talloc_get_type(s->ctx, struct samba_kdc_entry); - k->e_data = (void *)skdc_entry; + k->e_data = (void *)skdc_entry; - talloc_set_destructor(skdc_entry, samba_kdc_kdb_entry_destructor); + talloc_set_destructor(skdc_entry, + samba_kdc_kdb_entry_destructor); + } return sdb_entry_ex_to_krb5_db_entry(context, &s->entry, k); }