From: Volker Lendecke Date: Thu, 28 Nov 2024 11:09:50 +0000 (+0100) Subject: libcli: Use dom_sid_dup() instead of talloc_memdup() X-Git-Tag: tdb-1.4.13~424 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0045975c9e4c58356ace19328e59f5af094f162c;p=thirdparty%2Fsamba.git libcli: Use dom_sid_dup() instead of talloc_memdup() We have specialized code for this, why not use it... Signed-off-by: Volker Lendecke Reviewed-by: Martin Schwenke --- diff --git a/libcli/security/create_descriptor.c b/libcli/security/create_descriptor.c index b85b5411148..d8575f59b8b 100644 --- a/libcli/security/create_descriptor.c +++ b/libcli/security/create_descriptor.c @@ -652,8 +652,8 @@ struct security_descriptor *create_security_descriptor( new_group = creator_sd->group_sid; } - new_sd->owner_sid = talloc_memdup(new_sd, new_owner, sizeof(struct dom_sid)); - new_sd->group_sid = talloc_memdup(new_sd, new_group, sizeof(struct dom_sid)); + new_sd->owner_sid = dom_sid_dup(new_sd, new_owner); + new_sd->group_sid = dom_sid_dup(new_sd, new_group); if (!new_sd->owner_sid || !new_sd->group_sid){ talloc_free(new_sd); return NULL;