From: Volker Lendecke <vl@samba.org>
Date: Thu, 25 Sep 2025 06:55:34 +0000 (+0200)
Subject: smbd: Remove "dst_original_lcomp" from smb2_parse_file_rename_information()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=006c7440c4c383f72547050c488886918c8ff337;p=thirdparty%2Fsamba.git

smbd: Remove "dst_original_lcomp" from smb2_parse_file_rename_information()

Nobody uses it anymore

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
index c24ded34f28..ffdafa10470 100644
--- a/source3/smbd/smb2_trans2.c
+++ b/source3/smbd/smb2_trans2.c
@@ -4253,7 +4253,6 @@ NTSTATUS smb2_parse_file_rename_information(
 	char *newname = NULL;
 	struct files_struct *dst_dirfsp = NULL;
 	struct smb_filename *smb_fname_dst = NULL;
-	char *dst_original_lcomp = NULL;
 	uint32_t ucf_flags = ucf_flags_from_smb_request(req);
 	bool overwrite = false;
 	uint32_t len;
@@ -4325,20 +4324,6 @@ NTSTATUS smb2_parse_file_rename_information(
 		return status;
 	}
 
-	/*
-	 * Set the original last component, since
-	 * rename_internals_fsp() requires it.
-	 */
-	dst_original_lcomp = get_original_lcomp(smb_fname_dst,
-					conn,
-					newname,
-					ucf_flags);
-	if (dst_original_lcomp == NULL) {
-		TALLOC_FREE(newname);
-		TALLOC_FREE(smb_fname_dst);
-		return NT_STATUS_NO_MEMORY;
-	}
-
 done:
 	*_newname = newname;
 	*_overwrite = overwrite;