From: Sergey <bizywiz@gmail.com>
Date: Tue, 29 Oct 2019 05:10:24 +0000 (+0300)
Subject: Permutations Python code equivalent in comment was invalid for Python 3 (GH-16927)
X-Git-Tag: v3.9.0a1~109
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0078a0c2a59a358fa032ec9847c108378b66b656;p=thirdparty%2FPython%2Fcpython.git

Permutations Python code equivalent in comment was invalid for Python 3 (GH-16927)
---

diff --git a/Modules/itertoolsmodule.c b/Modules/itertoolsmodule.c
index e60ad5bec43c..3d39fa2e4737 100644
--- a/Modules/itertoolsmodule.c
+++ b/Modules/itertoolsmodule.c
@@ -3076,12 +3076,15 @@ static PyTypeObject cwr_type = {
 /* permutations object ********************************************************
 
 def permutations(iterable, r=None):
-    'permutations(range(3), 2) --> (0,1) (0,2) (1,0) (1,2) (2,0) (2,1)'
+    # permutations('ABCD', 2) --> AB AC AD BA BC BD CA CB CD DA DB DC
+    # permutations(range(3)) --> 012 021 102 120 201 210
     pool = tuple(iterable)
     n = len(pool)
     r = n if r is None else r
-    indices = range(n)
-    cycles = range(n-r+1, n+1)[::-1]
+    if r > n:
+        return
+    indices = list(range(n))
+    cycles = list(range(n, n-r, -1))
     yield tuple(pool[i] for i in indices[:r])
     while n:
         for i in reversed(range(r)):