From: Michele Baldessari <michele@acksyn.org>
Date: Mon, 10 Sep 2012 21:58:28 +0000 (-0700)
Subject: Set trans to a value that is not LDB_SUCCESS (all LDB_ constants are
X-Git-Tag: samba-4.0.0rc1~89
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=008bb29023ed6875d4ed2def0976b55051de02bf;p=thirdparty%2Fsamba.git

Set trans to a value that is not LDB_SUCCESS (all LDB_ constants are
positive) so that any "goto failed:" call does not end up calling
ldb_transaction_cancel() if trans is initialized to 0 (LDB_SUCCESS)
by chance.

Signed-off-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/winbind/idmap.c b/source4/winbind/idmap.c
index 976a2d0f9d3..a6cc88f8278 100644
--- a/source4/winbind/idmap.c
+++ b/source4/winbind/idmap.c
@@ -387,7 +387,7 @@ static NTSTATUS idmap_sid_to_xid(struct idmap_context *idmap_ctx,
 	struct ldb_dn *dn;
 	struct ldb_message *hwm_msg, *map_msg, *sam_msg;
 	struct ldb_result *res = NULL;
-	int trans;
+	int trans = -1;
 	uint32_t low, high, hwm, new_xid;
 	char *sid_string, *unixid_string, *hwm_string;
 	bool hwm_entry_exists;