From: Timo Sirainen <tss@iki.fi>
Date: Thu, 18 Nov 2010 18:57:18 +0000 (+0000)
Subject: pop3: Avoid crash when updating proctitle if client init fails.
X-Git-Tag: 2.0.8~66
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=00a297eb7e511111af80b475314622c98d49dd5b;p=thirdparty%2Fdovecot%2Fcore.git

pop3: Avoid crash when updating proctitle if client init fails.
---

diff --git a/src/pop3/pop3-client.c b/src/pop3/pop3-client.c
index 125aa60d69..693f86173f 100644
--- a/src/pop3/pop3-client.c
+++ b/src/pop3/pop3-client.c
@@ -252,8 +252,6 @@ struct client *client_create(int fd_in, int fd_out, struct mail_user *user,
 	net_set_nonblock(fd_in, TRUE);
 	net_set_nonblock(fd_out, TRUE);
 
-	pop3_client_count++;
-
 	client = i_new(struct client, 1);
 	client->service_user = service_user;
 	client->set = set;
@@ -274,6 +272,9 @@ struct client *client_create(int fd_in, int fd_out, struct mail_user *user,
 
 	client->user = user;
 
+	pop3_client_count++;
+	DLLIST_PREPEND(&pop3_clients, client);
+
 	inbox = "INBOX";
 	ns = mail_namespace_find(user->namespaces, &inbox);
 	if (ns == NULL) {
@@ -326,7 +327,6 @@ struct client *client_create(int fd_in, int fd_out, struct mail_user *user,
 		client->anvil_sent = TRUE;
 	}
 
-	DLLIST_PREPEND(&pop3_clients, client);
 	if (hook_client_created != NULL)
 		hook_client_created(&client);