From: Mark Michelson <mmichelson@digium.com>
Date: Mon, 13 Apr 2009 19:31:48 +0000 (+0000)
Subject: Fix another crash related to cached realtime music on hold.
X-Git-Tag: 11.0.0-beta1~5060
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0102e6cc44654de468686fbdaf1961be30162b68;p=thirdparty%2Fasterisk.git

Fix another crash related to cached realtime music on hold.

This was another off-by-one problem caused by moh_register.



git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@188102 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/res/res_musiconhold.c b/res/res_musiconhold.c
index 01920e0875..c1ab05dac4 100644
--- a/res/res_musiconhold.c
+++ b/res/res_musiconhold.c
@@ -1072,7 +1072,9 @@ static int moh_register(struct mohclass *moh, int reload, int unref)
 		if (!mohclass->delete) {
  			ast_log(LOG_WARNING, "Music on Hold class '%s' already exists\n", moh->name);
 			mohclass = mohclass_unref(mohclass, "unreffing mohclass we just found by name");
-			moh = mohclass_unref(moh, "unreffing potential new moh class (it is a duplicate)");
+			if (unref) {
+				moh = mohclass_unref(moh, "unreffing potential new moh class (it is a duplicate)");
+			}
 			return -1;
 		}
 		mohclass = mohclass_unref(mohclass, "Unreffing mohclass we just found by name");