From: Muraoka Taro Date: Sat, 3 Jan 2026 11:06:30 +0000 (+0000) Subject: CI: Missing test of Vim with ConPTY on Windows X-Git-Tag: v9.1.2046~3 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0115da33b468ca1a23967d38f3bad0e1dee19848;p=thirdparty%2Fvim.git CI: Missing test of Vim with ConPTY on Windows Problem: Current CI Windows testing does not test Vim using ConPTY. Solution: Added a configuration to enable ConPTY to the Windows matrix. This configuration suppresses the installation of winpty, allowing testing with ConPTY. Since the fixes made at the end of last year, all tests now pass when using ConPTY, just like when using winpty. ConPTY itself is stable on recent versions of Windows, so there are no longer any reasons not to test it. closes: #19066 Signed-off-by: Muraoka Taro Signed-off-by: Christian Brabandt --- diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5660d978b4..a3f2c81c99 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -522,6 +522,7 @@ jobs: - { features: HUGE, toolchain: mingw, VIMDLL: yes, GUI: yes, arch: x86, python3: stable, coverage: yes } - { features: HUGE, toolchain: msvc, VIMDLL: no, GUI: yes, arch: x86 } - { features: HUGE, toolchain: mingw, VIMDLL: yes, GUI: no, arch: x64, coverage: yes } + - { features: HUGE, toolchain: msvc, VIMDLL: no, GUI: no, arch: x64, ttytype: conpty } - { features: NORMAL, toolchain: msvc, VIMDLL: yes, GUI: no, arch: x86 } - { features: NORMAL, toolchain: mingw, VIMDLL: no, GUI: yes, arch: x64 } - { features: TINY, toolchain: msvc, VIMDLL: yes, GUI: yes, arch: x64 } @@ -616,11 +617,13 @@ jobs: call :downloadfile %LUA${{ env.BITS }}_URL% downloads\lua.zip 7z x downloads\lua.zip -o%LUA_DIR% > nul || exit 1 - echo %COL_GREEN%Download winpty%COL_RESET% - call :downloadfile %WINPTY_URL% downloads\winpty.zip - 7z x -y downloads\winpty.zip -oD:\winpty > nul || exit 1 - copy /Y D:\winpty\%WARCH%\bin\winpty.dll src\winpty%BITS%.dll - copy /Y D:\winpty\%WARCH%\bin\winpty-agent.exe src\ + if not "${{ matrix.ttytype }}" == "conpty" ( + echo %COL_GREEN%Download winpty%COL_RESET% + call :downloadfile %WINPTY_URL% downloads\winpty.zip + 7z x -y downloads\winpty.zip -oD:\winpty > nul || exit 1 + copy /Y D:\winpty\%WARCH%\bin\winpty.dll src\winpty%BITS%.dll + copy /Y D:\winpty\%WARCH%\bin\winpty-agent.exe src\ + ) echo %COL_GREEN%Download libsodium%COL_RESET% if "${{ matrix.toolchain }}"=="msvc" (