From: Alan T. DeKok <aland@freeradius.org>
Date: Tue, 20 Apr 2021 09:51:34 +0000 (-0400)
Subject: return dbuff values, not intermediate variables
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=01161edfce8a96fd940fc37b3a361322317d4112;p=thirdparty%2Ffreeradius-server.git

return dbuff values, not intermediate variables
---

diff --git a/src/protocols/radius/encode.c b/src/protocols/radius/encode.c
index 1c8e03a6295..305f724aef0 100644
--- a/src/protocols/radius/encode.c
+++ b/src/protocols/radius/encode.c
@@ -825,8 +825,7 @@ static ssize_t encode_extended(fr_dbuff_t *dbuff,
 		slen = attr_fragment(&work_dbuff, (size_t)vendor_hdr + slen, &hdr, 4, 3, 0);
 		if (slen <= 0) return slen;
 
-		fr_dbuff_set(dbuff, &work_dbuff);
-		return slen;
+		return fr_dbuff_set(dbuff, &work_dbuff);
 	}
 
 	fr_dbuff_in_bytes(&length_field, (uint8_t) fr_dbuff_used(&work_dbuff));
@@ -1100,8 +1099,7 @@ static ssize_t encode_wimax(fr_dbuff_t *dbuff,
 		slen = attr_fragment(&work_dbuff, (size_t)slen, &hdr, 9, 8, 7);
 		if (slen <= 0) return slen;
 
-		fr_dbuff_set(dbuff, &work_dbuff);
-		return slen;
+		return fr_dbuff_set(dbuff, &work_dbuff);
 	}
 
 	fr_dbuff_in_bytes(&vsa_length_field, (uint8_t) (fr_dbuff_used(&work_dbuff) - 6));