From: Timo Sirainen <tss@iki.fi>
Date: Fri, 20 Aug 2010 18:45:01 +0000 (+0100)
Subject: lib-storage: Give better error message if user is missing UID/GID
X-Git-Tag: 2.0.1~23
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=0139fcb57a88f6ed27a1bb4a1bd537b04fd2b5d6;p=thirdparty%2Fdovecot%2Fcore.git

lib-storage: Give better error message if user is missing UID/GID
---

diff --git a/src/lib-storage/mail-storage-service.c b/src/lib-storage/mail-storage-service.c
index 794468e890..92282004aa 100644
--- a/src/lib-storage/mail-storage-service.c
+++ b/src/lib-storage/mail-storage-service.c
@@ -317,6 +317,9 @@ service_drop_privileges(const struct mail_user_settings *set,
 				dec2str(rset.uid));
 			return -1;
 		}
+	} else if (rset.uid == (uid_t)-1) {
+		*error_r = "User is missing UID (see mail_uid setting)";
+		return -1;
 	}
 	if (*set->mail_gid != '\0') {
 		if (!parse_gid(set->mail_gid, &rset.gid)) {
@@ -333,6 +336,9 @@ service_drop_privileges(const struct mail_user_settings *set,
 				dec2str(rset.gid));
 			return -1;
 		}
+	} else if (rset.gid == (gid_t)-1) {
+		*error_r = "User is missing GID (see mail_gid setting)";
+		return -1;
 	}
 	if (*set->mail_privileged_group != '\0') {
 		if (!parse_gid(set->mail_privileged_group, &rset.privileged_gid)) {