From: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Date: Sat, 27 Aug 2022 11:13:19 +0000 (+0100)
Subject: gh-92007: Handle elevation errors in NTEventLogHandler more grace… (GH-96322)
X-Git-Tag: v3.12.0a1~546
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=013e659e495796df77aae4d33b67995f9793f454;p=thirdparty%2FPython%2Fcpython.git

gh-92007: Handle elevation errors in NTEventLogHandler more grace… (GH-96322)
---

diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index 3f97862cc37a..b4c5c1304b97 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -1111,7 +1111,16 @@ class NTEventLogHandler(logging.Handler):
                 dllname = os.path.join(dllname[0], r'win32service.pyd')
             self.dllname = dllname
             self.logtype = logtype
-            self._welu.AddSourceToRegistry(appname, dllname, logtype)
+            # Administrative privileges are required to add a source to the registry.
+            # This may not be available for a user that just wants to add to an
+            # existing source - handle this specific case.
+            try:
+                self._welu.AddSourceToRegistry(appname, dllname, logtype)
+            except Exception as e:
+                # This will probably be a pywintypes.error. Only raise if it's not
+                # an "access denied" error, else let it pass
+                if getattr(e, 'winerror', None) != 5:  # not access denied
+                    raise
             self.deftype = win32evtlog.EVENTLOG_ERROR_TYPE
             self.typemap = {
                 logging.DEBUG   : win32evtlog.EVENTLOG_INFORMATION_TYPE,