From: Volker Lendecke <vl@samba.org>
Date: Fri, 30 Mar 2018 14:23:07 +0000 (-0500)
Subject: krb5_wrap: Fix CID 1034833 Resource leak
X-Git-Tag: talloc-2.1.13~50
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=015e04660ccd340b65feedb2954062f614b400f7;p=thirdparty%2Fsamba.git

krb5_wrap: Fix CID 1034833 Resource leak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/lib/krb5_wrap/keytab_util.c b/lib/krb5_wrap/keytab_util.c
index f9a8679290c..fd8308cedfe 100644
--- a/lib/krb5_wrap/keytab_util.c
+++ b/lib/krb5_wrap/keytab_util.c
@@ -179,12 +179,14 @@ krb5_error_code kt_copy_one_principal(krb5_context context,
 
     ret = krb5_kt_resolve (context, from, &src_keytab);
     if (ret) {
+	krb5_free_principal(context, princ);
 	krb5_set_error_message(context, ret, "resolving src keytab `%s'", from);
 	return ret;
     }
 
     ret = krb5_kt_resolve (context, to, &dst_keytab);
     if (ret) {
+	krb5_free_principal(context, princ);
 	krb5_kt_close (context, src_keytab);
 	krb5_set_error_message(context, ret, "resolving dst keytab `%s'", to);
 	return ret;
@@ -223,6 +225,7 @@ krb5_error_code kt_copy_one_principal(krb5_context context,
 	}
     }
 
+    krb5_free_principal(context, princ);
     krb5_kt_close (context, src_keytab);
     krb5_kt_close (context, dst_keytab);
     return ret;